Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collect declarations in textDocument/references implementation #123

Open
wants to merge 1 commit into
base: spr/main/c0e7d4d8
Choose a base branch
from
Open

Collect declarations in textDocument/references implementation #123

wants to merge 1 commit into from

Conversation

mkaput
Copy link
Member

@mkaput mkaput commented Dec 20, 2024 •
edited
Loading

@mkaput mkaput requested a review from a team as a code owner December 20, 2024 12:40
@mkaput mkaput requested review from Arcticae and Draggu and removed request for a team December 20, 2024 12:40
This was referenced Dec 20, 2024
Open
Open
Merged
Open
Arcticae
Arcticae approved these changes Dec 20, 2024
View reviewed changes
src/lang/inspect/refs.rs
/// Location where searched symbol is declared.
///
/// This can rarely be `None`, for example, for macros.
pub declaration: Option<(FileId, TextSpan)>,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this can also be none if you're using it by clicking the declaration (it's the same request, am i right?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arcticae Arcticae Arcticae approved these changes

@Draggu Draggu Awaiting requested review from Draggu Draggu is a code owner automatically assigned from software-mansion/cairo-ls

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mkaput @Arcticae