Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminate compositor when parent process is terminated #787

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

wkozyra95
Copy link
Member

No description provided.

@wkozyra95 wkozyra95 force-pushed the @wkozyra95/ts-sdk-detect-ffmpeg branch from ab69873 to 4780612 Compare September 24, 2024 13:02
Base automatically changed from @wkozyra95/ts-sdk-detect-ffmpeg to master September 24, 2024 13:49
@wkozyra95 wkozyra95 force-pushed the @wkozyra95/detect-ppid-change branch from e77ffc6 to 8040e3b Compare September 24, 2024 15:45
@wkozyra95 wkozyra95 marked this pull request as ready for review September 24, 2024 15:45
src/server.rs Outdated
@@ -12,6 +12,7 @@ use crate::{config::read_config, logger::init_logger, routes::routes, state::Api
pub fn run() {
let config = read_config();
init_logger(config.logger.clone());
listen_for_parent_termination();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since listen_for_parent_termination depends on correctly reading parent_id (parent process is not killed before let ppid = parent_id(); executes), I would put it as a first call in the run command.

@wkozyra95 wkozyra95 force-pushed the @wkozyra95/detect-ppid-change branch from 8040e3b to 0e0340b Compare September 26, 2024 08:10
@wkozyra95 wkozyra95 merged commit e7ede1f into master Sep 26, 2024
3 checks passed
@wkozyra95 wkozyra95 deleted the @wkozyra95/detect-ppid-change branch September 26, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants