Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat: adds a hotkey to open dev menu (#167)
**Description** Closes #148 [Loom video demo](https://www.loom.com/share/c2620acb13c8484387f22590f4bdab88?sid=256a27d7-f5ff-4147-ba21-bd8d5032accc) A few notes and questions: - I went with `cmd + ctrl + z` because I didn't want to interfere with `cmd + d` which is already a command that is handled by the simulator (also because `cmd + d` is a bit buggy on Expo projects and opens a different menu than this one). Another reason I choose this is because `cmd + ctrl + z` is the default to shake the device on the simulator for iOS. **We can change this if needed as I'm sure I may get some push back to use `cmd + d` or `cmd + ctrl + d`.** <img width="367" alt="Screenshot 2024-04-26 at 3 07 13 PM" src="https://github.com/software-mansion/react-native-ide/assets/3059371/bbe109df-ea89-44fb-b55c-c4cee4161d80"> <br /><br /> - You can see the keybinding can be changed in the keybinding menu in VSCode. For Mac its Code -> Settings -> Keyboard Shortcuts then search for "React Native IDE" to change the `openDevMenu` keybinding <img width="1552" alt="Screenshot 2024-05-10 at 12 21 54 PM" src="https://github.com/software-mansion/react-native-ide/assets/3059371/16c4671c-22ab-4c20-aa2e-38919f05a458"> **TODOs** - [x] Decide on what key binding should be the default keybinding (I've decided on `cmd + ctrl + z` as the default keybinding see my rationale [here](#167 (comment))) - [x] Test that the key binding can be customized at will via the VSCode UI (I've tested it and it works see my [loom video](https://www.loom.com/share/c2620acb13c8484387f22590f4bdab88?sid=256a27d7-f5ff-4147-ba21-bd8d5032accc)) **How to test** 1. Run the extension following these [steps](https://ide.swmansion.com/docs/development#development-setup) 2. Open a test project as described in those steps 3. Press `cmd + ctrl + z` at any point 4. Change the keybinding for Mac its Code -> Settings -> Keyboard Shortcuts then search for "React Native IDE" to change the `openDevMenu` keybinding **Screenshot** <img width="1552" alt="Screenshot 2024-04-26 at 3 10 16 PM" src="https://github.com/software-mansion/react-native-ide/assets/3059371/6bb2e326-ce2f-4a2e-ac31-54d46d8c71d5">
- Loading branch information