Fix application console.log output #168
Conversation
|
Someone is attempting to deploy this pull request to the software-mansion Team on Vercel. To accomplish this, the commit author's email address needs to be associated with a GitHub account. Learn more about how to change the commit author information. |
filip131311
changed the title
filip131311
changed the title
| depth: number, | ||
| prefix?: string | ||
| ): Promise<FormmatedLog> { | ||
| if (depth > MAX_OBJECT_DEPTH) { |
There was a problem hiding this comment.
This prevents infinite call.
| @@ -30,6 +32,16 @@ export type CDPDebuggerScope = { | |||
| object: CDPRemoteObject & { type: "object" }; | |||
| }; | |||
|
|
|||
| export type FormmatedLog = { | |||
There was a problem hiding this comment.
Typo: replace FormmatedLog with FormatedLog
There was a problem hiding this comment.
❓ What does prefix, indented, and unindented do?
| // For now this is a neccesery workaround, because of a bug in vs code that prevents "source" and "group" properties to work together | ||
| // TODO: monitore if the bug was solved and remove Source Event https://github.com/microsoft/vscode/issues/212304 |
There was a problem hiding this comment.
Typo in "neccesery" and "monitore".
There was a problem hiding this comment.
By the way, the comment doesn't explain why the workaround is here. I don't understand why it's even needed in the first place.
| sourceEvent.body = { | ||
| ...sourceEvent.body, | ||
| category: log.category, | ||
| //@ts-ignore source, line, column and group are valid fieleds |
| }; | ||
| this.sendEvent(startCollapsedEvent); | ||
|
|
||
| log.indented.map((item) => { |
There was a problem hiding this comment.
This should be forEach or even better, for-of loop.
| .map((item) => { | ||
| return item?.unindented; | ||
| }) | ||
| .join(" ") | ||
| .slice(0, 79); |
There was a problem hiding this comment.
- 80 line length should be extracted to some constant.
- This probably isn't a bottleneck but joining all things just to drop everything after 80 characters feels wasteful.
- nit:
.map((item) => {
return item?.unindented;
})
// same as
.map(({unindented}) => unindented)| break; | ||
| case "function": | ||
| res.indented.push({ | ||
| unindented: prop.name + ": " + (prop.description || function () {}), |
There was a problem hiding this comment.
Why we're converting function to string as fallback to description?
| }); | ||
| return format(obj); | ||
| const res = { |
jakub-gonet
changed the title
There was a problem hiding this comment.
I think that we should use the same approach vscode-js-debug uses. Apparently debugadapter module we use from NPM doesn't have all the properties of OutpuEvent, but both spec and vscode-js-debug have variableReference prop which I think we should be using here instead:
https://microsoft.github.io/debug-adapter-protocol/specification#Events_Output
https://github.com/microsoft/vscode-js-debug/blob/main/src/dap/api.d.ts#L2872
…executionContextsCleared and clean the console
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This PR fixes a problem with simulated application logs not outputting objects correctly.
Fixes: #161
This PR adds indenting for objects and treats every console.log argument as a filed (consistently with how native vscode debugConsole works). To achieve this a "virtual" root object is created and a variablesRefrence to this object is passed into OutputEvent.
Before:
Screen.Recording.2024-04-27.at.00.24.47.mov
After:
Screen.Recording.2024-05-14.at.02.08.01.mov