Distinct platform dependencies check #262
Conversation
|
@jakub-gonet is attempting to deploy a commit to the software-mansion Team on Vercel. To accomplish this, @jakub-gonet needs to request access to the Team. Afterwards, an owner of the Team is required to accept their membership request. If you're already a member of the respective Vercel Team, make sure that your Personal Vercel Account is connected to your GitHub account. |
jakub-gonet
requested review from
kacperkapusciak and
kmagiera
and removed request for
kmagiera and
kacperkapusciak
|
Seems like I can assign only one reviewer. I'd you both to look at it, if possible. |
jakub-gonet
force-pushed
the
jgonet/platform-dependencies-check
branch
from
897c453
to
8ce7292
Compare
| async function createDevice() { | ||
| if (!selectedSystemName) { | ||
| return; | ||
| } | ||
|
|
||
| setLoading(true); |
There was a problem hiding this comment.
I left them as they were but early returns in this function seem like an error – we never call setLoading(false) then. Same for empty devices list view.
| const firstIosDeviceName = iOSSupportedDevices[0].name; | ||
| const firstAndroidDeviceName = AndroidSupportedDevices[0].name; | ||
|
|
||
| function getMax<T>(array: T[], predicate: (element: T, currentMax: T) => boolean): T | undefined { |
| <span className="codicon codicon-add" /> | ||
| Create new device | ||
| </Button> | ||
| <> |
There was a problem hiding this comment.
TODO: Remove empty tags.
| @@ -21,7 +21,7 @@ class VSCodeAPIWrapper { | |||
| * @remarks When running webview code inside a web browser, postMessage will instead | |||
| * log the given message to the console. | |||
| * | |||
| * @param message Abitrary data (must be JSON serializable) to send to the extension context. | |||
| * @param {{command: string} & Record<string, unknown>} message - Arbitrary data (must be JSON serializable) to send to the extension context. | |||
There was a problem hiding this comment.
To we get any typing.
| import { Logger } from "../Logger"; | ||
| import { extensionContext } from "../utilities/extensionContext"; | ||
| import { WorkspaceConfigController } from "./WorkspaceConfigController"; | ||
| import { getTelemetryReporter } from "../utilities/telemetry"; | ||
|
|
||
| type CallArgs = { |
There was a problem hiding this comment.
method and args could be typed more precisely but it's a good start I think.
This PR allows using iOS and Android independently.
If Android/iOS tools are not installed, we block managing them, as well as disabling buttons for creating new devices in empty state.
We also don't show notification about missing dependencies on the other platform.
I don't particularly like
isSomethingErrorAPI, the alternative is to provideerrorsobject with scoped domains or access.errorfield on dependencies directly.Screenshots/videos
android.mov
ios.mov
Test plan
When using studio for the first time:
After creating new device
Switching between devices still works (we don't handle when environment change when IDE is open).
Known error: we show "Check diagnostics" message in creation modal but it's not accessible in the empty view.
Fixes #173