fix: add bundle command as a fallback to CocoaPods check
#304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jakub-gonet
reviewed
May 27, 2024
| isCocoaPodsInstalled = await checkIfCLIInstalled("bundle exec pod --version", { | ||
| env, | ||
| // Run the command in the current project directory | ||
| cwd: workspace.workspaceFolders?.[0].uri.fsPath, |
There was a problem hiding this comment.
Can we safely assume that first workspace directory is always an app directory?
There was a problem hiding this comment.
Not always, it largely depends on the users' setup but this is a fair try IMHO.
We could attempt to look for the correct folder within the fsPath, though.
| const installed = await checkIfCLIInstalled("pod --version", { | ||
| env: { ...process.env, LANG: "en_US.UTF-8" }, | ||
| const env = { ...process.env, LANG: "en_US.UTF-8" }; | ||
| let isCocoaPodsInstalled = await checkIfCLIInstalled("pod --version", { |
There was a problem hiding this comment.
Nit: Can we fit it in the one line please?
| }); | ||
|
|
||
| // If `pod --version` fails, try `bundle exec pod --version` as a second attempt | ||
| if (!isCocoaPodsInstalled && workspace.workspaceFolders?.length) { |
There was a problem hiding this comment.
Nit: can we please make it more explicit? workspace.workspaceFolders?.length > 0
|
This wasn't active for quite a while now so I'm closing it. If need arises, we will reimplement it in the future. Thanks! |
kmagiera
added a commit
that referenced
this pull request
Oct 14, 2024
This is a draft as it is build on top of #615 This PR refactors the way we install pods in the IDE. The main objective is to optionally use `bundle` command. This is similar to the changes proposed in #304 but apart from using bundle for the diagnostics check, we also use it when installing (which is a mechanism that wasn't in place when #304 was created). The second main change that we're making is that we trigger pod installation when clean build is requested. Before that wasn't happening. On top of that, we are including pod command output in the iOS build log. This will help diagnose potential problems better and will also provide some feedback for the scenarios when installation take very long. Finally, we are fixing the startup message component such that it resets long wait flag and we are also adding a more prominent message "open logs" for the native build phase. This way it should be easier to spot for the users that they can see the build output in case the build takes long: <img width="360" alt="image" src="https://github.com/user-attachments/assets/64ea681c-1b9a-498c-98ef-c4afbe2826fc"> ### How Has This Been Tested: 1. Run clean build in on of the test apps for iOS. See cocoapods in the log output 2. Run RN 76 example on iOS to see bundle being used there instead of pod install (check logs) 3. When building on iOS, see that the "open logs" text appears in the startup message and you can click it to open the logs output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #303.
This PR adds
bundle exec pod --versionas a "second attempt" to verify that CocoaPods is installed, the current implementation that's solely relying inpod --versionto check for CocoaPods installation will fail in projects using Bundler.Since
bundlecommands are tied to the specific project installation, it's necessary to execute the command from within the project directory path.