Add static geolocation #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jakub-gonet
previously requested changes
May 28, 2024
packages/vscode-extension/src/webview/views/DeviceLocationView.tsx
Outdated
Show resolved
Hide resolved
kacperkapusciak
previously requested changes
May 29, 2024
packages/vscode-extension/src/webview/views/DeviceLocationView.tsx
Outdated
Show resolved
Hide resolved
packages/vscode-extension/src/webview/views/DeviceLocationView.tsx
Outdated
Show resolved
Hide resolved
packages/vscode-extension/src/webview/views/DeviceLocationView.tsx
Outdated
Show resolved
Hide resolved
packages/vscode-extension/src/webview/views/DeviceLocationView.tsx
Outdated
Show resolved
Hide resolved
packages/vscode-extension/src/webview/views/DeviceLocationView.tsx
Outdated
Show resolved
Hide resolved
kmagiera
requested changes
Jun 3, 2024
There was a problem hiding this comment.
We discussed this over call but posting high level comments such that they don't get lost:
- let's accept single line input for coords and allow different formatting (use some js libfor parsing). It is convinient to be able to paste the coords from somewhere instead of interacting with four separate controls
- don't put form controls below "save" button, the enable/disable switch should be first actually
- we don't need save, let's just save on change assuming the provided coords are valid
kmagiera
approved these changes
Jun 10, 2024
| @@ -27,3 +27,25 @@ export function throttle<T extends (...args: any[]) => any>( | |||
| recentArgs = args; | |||
| } as T; | |||
| } | |||
|
|
|||
| export function throttleWithTrailing<T extends (...args: any[]) => any>( | |||
There was a problem hiding this comment.
how is this different than "throttle"? Maybe add some comment here? Also from reading the code it appears like you can actually use the existing method, no?
….tsx Co-authored-by: Kacper Kapuściak <39658211+kacperkapusciak@users.noreply.github.com>
filip131311
force-pushed
the
@Filip131311/AddLocation
branch
from
94cf834
to
9970683
Compare
jakub-gonet
reviewed
Jun 10, 2024
Comment on lines
+94
to
+110
| if (settings.location.isDisabled) { | ||
| await exec("xcrun", [ | ||
| "simctl", | ||
| "--set", | ||
| deviceSetLocation, | ||
| "location", | ||
| this.deviceUDID, | ||
| "clear", | ||
| ]); | ||
| } else { | ||
| await exec("xcrun", [ | ||
| "simctl", | ||
| "--set", | ||
| deviceSetLocation, | ||
| "location", | ||
| this.deviceUDID, | ||
| "set", |
There was a problem hiding this comment.
Nit:
await exec("xcrun", [
"simctl",
"--set",
deviceSetLocation,
"location",
this.deviceUDID,
settings.location.isDisabled ? "clear" : "set",
]);
Comment on lines
+68
to
+69
| latitude: 50.048653, | ||
| longitude: 19.965474, |
There was a problem hiding this comment.
Won't block on this but I still think we shouldn't default to any location.
| text-align: center; | ||
| height: 42px; | ||
| align-self: right; | ||
| /* margin-left: 5px; */ |
| const { project, deviceSettings } = useProject(); | ||
| const inputRef = useRef<HTMLInputElement>(null); | ||
|
|
||
| const updateProjectSettingWithThrottle = throttleWithTrailing( |
There was a problem hiding this comment.
Can't we use blur events instead of throttling change events?
Comment on lines
+74
to
+78
| const convertDDToDMS = (D: number, lng: boolean) => { | ||
| return { | ||
| dir: D < 0 ? (lng ? "W" : "S") : lng ? "E" : "N", | ||
| deg: 0 | (D < 0 ? (D = -D) : D), | ||
| min: String(0 | (((D += 1e-9) % 1) * 60)).padStart(2, "0"), | ||
| sec: String(Math.floor((0 | (((D * 60) % 1) * 6000)) / 100)).padStart(2, "0"), | ||
| }; | ||
| }; |
There was a problem hiding this comment.
Can you drop a comment what DD and DMS is? Assuming the code is copied from somewhere, would be nice to have a source URL.
| <label className="latitude"> | ||
| <div className="picker"> | ||
| <input | ||
| ref={inputRef} |
There was a problem hiding this comment.
I wonder if it isn't easier to make it controlled input.
Comment on lines
+53
to
+59
| try { | ||
| position = new CoordinateParser(newCoordinate); | ||
| setIsCoordinateValid(true); | ||
| } catch (e) { | ||
| setIsCoordinateValid(false); | ||
| return; | ||
| } |
There was a problem hiding this comment.
I don't particularly like it. What do you think about some small helper function to return lat, long?
If it returns nice error, we can also try to pass it to user.
function parseCoords(raw: string) {
try {
const { getLatitude, getLongitude } = new CoordinateParser(newCoordinate);
return { latitude: getLatitude(), longitude: getLongitude() };
} catch (_e) {}
return undefined;
}
kmagiera
added a commit
that referenced
this pull request
Jun 10, 2024
In #317 new fields have been added to device settings. However, since we persist device settings, the changes are not compatible with the old data that might've been stored there. To prevent this we are adding a versioning of device settings key (will increment version with future changes). This PR also changes the defaults to use disabled location, especially that we need to have some coordinates specified, it'd be weird to have everyone using IDE pointing to the same geo location.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an ability to set static device location.
added functionality:
Screen.Recording.2024-06-06.at.16.02.55.mov
Screen.Recording.2024-06-06.at.16.05.48.mov
Fixes: #330