Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kmagiera/rn74 inspector #340

Merged
merged 2 commits into from
Jun 3, 2024
Merged

Kmagiera/rn74 inspector #340

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
86c1160
Use patched version of RN renderer for RN 0.74 to fix inspector
kmagiera Jun 3, 2024
2802b86
Add more context to why we override renderer
kmagiera Jun 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions packages/vscode-extension/lib/babel_transformer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,35 @@ function transformWrapper({ filename, src, ...rest }) {
}
} else if (filename.endsWith("node_modules/react-native-ide/index.js")) {
src = `${src};preview = require("__RNIDE_lib__/preview.js").preview;`;
} else if (
filename.endsWith(
"node_modules/react-native/Libraries/Renderer/implementations/ReactFabric-dev.js"
) ||
filename.endsWith(
"node_modules/react-native/Libraries/Renderer/implementations/ReactNativeRenderer-dev.js"
)
) {
// This is a temporary workaround for inspector in React Native 0.74
// The inspector broke in that version because of this commit that's been included
// in React Native renderer despite it not being a part of React 18 release: https://github.com/facebook/react/commit/37d901e2b8
// The commit changes the way metadata properties from jsx transforms are added to the elements.
// The workaround is to replace dev version of ReactNative renderer with the one build from exact
// same react version, but with that commit reverted. The version of react used in React Native 0.74
// comes from this commit: https://github.com/facebook/react/commit/03d6f7cf0
//
// The mentioned issue got later resolved in https://github.com/facebook/react/commit/61bd00498
// however, the new approach does not produce the same information as the debug entries only
// point to component definition lines rather than places where the component is used.
// There is also a follow-up attempt to bring back proper debug metadata in https://github.com/facebook/react/commit/151cce37401
// However, this commit is not included in React Native 0.74 and would require pulling in
// a lot of further changes along with it. Also, based on the commit message, this approach
// is experimental as it has some performance implications and may be removed in future versions.
//
const { version } = requireFromAppDir("react-native/package.json");
if (version.startsWith("0.74")) {
const rendererFileName = filename.split("/").pop();
src = `module.exports = require("__RNIDE_lib__/rn74/${rendererFileName}");`;
}
}

return transform({ filename, src, ...rest });
Expand Down
Loading