Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve detection whether we should use Expo CLI #351

Merged
merged 2 commits into from
Jun 6, 2024
Merged

Improve detection whether we should use Expo CLI #351

merged 2 commits into from
Jun 6, 2024

Conversation

kmagiera
Copy link
Member

@kmagiera kmagiera commented Jun 6, 2024

Fixes #318

This PR updates the way we detect whether project should use Expo CLI. There are two main changes here:

  1. In addition for checking whether expo cli is installed, we also verify that scrtips section in package json contains some expo commands (like "expo start" etc)
  2. We add launch configuration option for overriding this behavior and forcing the use of Expo CLI

@vercel Vercel
Copy link

vercel bot commented Jun 6, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-ide ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 6, 2024 10:33am

@kmagiera kmagiera merged commit a96a91c into main Jun 6, 2024
2 of 3 checks passed
@kmagiera kmagiera deleted the kmagiera/improve-expo-cli-detection branch June 6, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Custom Metro Config] expo-start.js script fails for Bare React Native project
1 participant
@kmagiera