Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce a cap for iOS build progress. #361

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

filip131311
Copy link
Collaborator

This PR solves an issue with iOS build Progress sometimes exceeds 100%.

Before:

Screen.Recording.2024-06-07.at.15.45.42.mov

After:

Screen.Recording.2024-06-07.at.15.56.48.mov

***recordings were made during a build of the same bare react native template.

Copy link

vercel bot commented Jun 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-ide ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 7, 2024 2:05pm

@filip131311 filip131311 requested a review from kmagiera June 7, 2024 14:06
Copy link
Member

@jakub-gonet jakub-gonet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this.completedTasks exceeds this.tasksToComplete?

@filip131311 filip131311 merged commit d07587b into main Jun 10, 2024
3 checks passed
@filip131311 filip131311 deleted the @Filip131311/FixIosBuildProgress branch June 10, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants