Replace disabled magnet with home button used e.g. for getting back from preview mode. #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using component preview in non expo-router projects, there is no way in the panel to go back to the main app from preview mode. Since we are not currently using the magnet functionality, I decided we could add "home" button that's similar to what browsers offer, and hence would provide an intuitive way of going back home from preview mode.
Since it sort-of doubles the reload functionality, we disable it unless url list is non-empty. This happens specifically when preview is opened (previews get appended to url list). But home button can also be used in expo-router projects to reset the stack to /