Avoid closing IDE accidentally

[kewinzaq1]

Problem

Currently, there is a chance of accidentally closing the IDE panel and it can be an unpleasant experience

Solution

Simple confirmation popup to avoid headaches. The following popup only appears if users click cmd+w/ctr+w
https://github.com/software-mansion/react-native-ide/assets/77052270/70c45f35-9d89-4b99-ad97-9f69e0cbc96e

#387

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
react-native-ide	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 26, 2024 4:31pm

[kmagiera]

Thanks for this. I like the idea but would suggest the following changes:

1. use onDidChangeActiveTextEditor instread of the tab group change event
2. register the event in Tabpanel instead of extension.ts and make sure we call dispose on the result of registration when dispose is triggered on the panel
3. Use panel.active field to tell whether the IDE panel is focused (https://code.visualstudio.com/api/references/vscode-api#WebviewPanel)
4. Rename isTabActive to isTabPanelFocused since word "active" is ambiguous in this context
5. Rename "doubleClickClose" to "closeWithConfirmation"

[kewinzaq1]

@kmagiera Thanks for the review.
I tried to go with onDidChangeActiveTextEditor however I ended up checking the active state 
this._panel.active before the update had happened, so I moved to the direct method on the panel; onDidChangeViewState allows for avoiding this problem pretty straightforwardly. What do you think about this approach?

[kmagiera]

This is much better. I'm ok with using onDidChangeViewState if it works and gets triggered at the right moment. Only added one more comment inline and this should be good to go.

[kmagiera]

This is great. Thanks for working on the requested changes!