Refresh preview on fast refresh #401
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| @@ -209,6 +216,10 @@ export function PreviewAppWrapper({ children, ...rest }) { | |||
| }; | |||
| LoadingView.hide = () => { | |||
| devtoolsAgent._bridge.send("RNIDE_fastRefreshComplete"); | |||
| if (isRunningPreview()) { | |||
| // refresh preview component | |||
| openPreview(getCurrentSceneName()); | |||
There was a problem hiding this comment.
I like all the other changes in this PR except for this one. It doesn't seem like the right choice to manually fix fast-refresh behavior. I wonder why does it in the main app but not in preview, and would expect it to "just work" here as well? Maybe it's because preview is the root element and fast refresh doesn't support it? Maybe it'd be enough to just wrap it in some other root component?
jakub-gonet
force-pushed
the
jgonet/refresh-preview-on-fast-refresh
branch
from
39eb555
to
f9dbad6
Compare
| onClick={() => project.goHome()} | ||
| onClick={() => { | ||
| project.goHome(); | ||
| setUrlList([]); |
There was a problem hiding this comment.
This isn't ideal but we relied on metro reload to do it for us. In the future, we need to keep / always in the URL list. I'll create a ticket for that.
| @@ -1,18 +1,21 @@ | |||
| import { useSyncExternalStore, useEffect } from "react"; | |||
| import { useRouter } from "expo-router"; | |||
| import { store } from "expo-router/build/global-state/router-store.js"; | |||
There was a problem hiding this comment.
Moved the store import to the top so it's more evident that those two files are different only there.
There was a problem hiding this comment.
Added some comments inline. Also please remove changes to navigation integration interface. If there are issues in expo router integration due to early navChange calls, this should be handled by that implementation alone. Also such changes shouldn't be a part of this PR as they seem to be fixing a different problem
| const SceneTracker = require("react-native/Libraries/Utilities/SceneTracker"); | ||
| const isRunningPreview = isPreviewUrl(SceneTracker.getActiveScene().name); | ||
| if (isRunningPreview) { | ||
| if (currentPreviewKey) { |
There was a problem hiding this comment.
maybe check active scene name, we don't need the exact preview name here as we only check if its running or not
| } | ||
|
|
||
| export function preview(component) { | ||
| if (component._source == null) { | ||
| if (!component || component._source === null) { |
There was a problem hiding this comment.
I think we may want to have == check here. I think _source could be undefined here too, and since it's internal field I wouldn't rely on it being set to null
jakub-gonet
force-pushed
the
jgonet/refresh-preview-on-fast-refresh
branch
from
ce8a8aa
to
173cba8
Compare
Fast refresh is triggered when props are changed in previewed component. We didn't accommodate for that previously, as we only rendered preview once, after clicking a button from code lenses.
Additionally:
preview()without any component.Fixes #288.