Avoid rebooting and rebuilding for certain type of restarts #424
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the way we handle restarts / reloads.
Before, when fast-refresh wasn't possible, we'd use
selectDevice
flow, which always kills the simulator process, restarts it, starts new preview etc. This tend to take long and definitely much longer than needed when we only want the app process to be restarted.An example when this scenario occurs frequently is when updating privacy permissions. In that case, the app process is killed by the system, and we need to restart it. Rebooting emulator in such a case is unnecessary.
The new restart flow now looks as follows:
Test plan:
this has been tested on top of permissions PR where I check that the app process restart is performed after resetting permissions.