Fix yarn workspaces

[filip131311]

This PR fixes node_modules detection for yarn workspaces and adds a working example of a set up in which workspaces are used.

relates to: #514

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
react-native-ide	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 29, 2024 10:57am

[jakub-gonet]

Would be nice to have an example in the comment above, like "yarn@3.6.4". I initially thought this was related to @xxx/yyy format.

regex name doesn't help at all, we can basically inline it IMO.

[jakub-gonet]

Tiny thing to consider: we could read the dir and the check existence in JS, should be faster than doing 4 syscalls. Probably doesn't matter though.

import fs from "node:fs/promises";

async f() {
  const lockFiles = new Map(
    Object.entries({
      "yarn.lock": "yarn",
      "package-lock.json": "npm",
      "pnpm-lock.yaml": "pnpm",
      "bun.lockb": "bun",
    } as const)
  );

  const files = await fs.readdir(workspace);
  for (const file of files) {
    const packageManager = lockFiles.get(file);
    if (packageManager) {
      return packageManager;
    }
  }
}

[jakub-gonet]

I think we should just read the file and catch if doesn't exist, something like that:

function walkDirectoriesUntilRoot(
  start: string,
  shouldStop: (current: string) => boolean
): string | undefined {
  let currentDir = start;
  let parentDir = path.resolve(currentDir, "..");
  while (parentDir !== currentDir) {
    currentDir = parentDir;
    parentDir = path.resolve(currentDir, "..");

    if (shouldStop(currentDir)) {
      return currentDir;
    }
  }
  return undefined;
}

function findWorkspace(appRoot: string) {
  return walkDirectoriesUntilRoot(appRoot, (currentDir) => {
    try {
      const packageJsonPath = path.join(currentDir, "package.json");
      const hasWorkspaces = require(packageJsonPath).workspaces !== undefined;
      return hasWorkspaces;
    } catch (error) {
      // No package.json
      return false;
    }
  });
}

[filip131311]

i did that just reaarengedsome functions to reuse code

[kmagiera]

add some text that says that in order to get rid of this error, people should specify app root in the launch configuration

[jakub-gonet]

Also, "lunch configuration" typo. 🥪

[DorianMazur]

This PR probably broke react-native-ide. Now node_modules don't work. I had to downgrade to 0.17

[filip131311]

@DorianMazur hello, thank you so much for your feedback would you mind sharing React Native IDE logs from 0.18 version with us? you can find them in the output section of your vscode. Why do you think it is this PR that broke it for you?

[DorianMazur]

I'm using yarn with corepack in a project and it basically can't find node_modules. After downgrading to 0.17 everything works like a charm.

I analyzed all commits between versions 0.18 and 0.17 and found only one that refers to node_modules. This one.