Fix wrapper to work on Windows #522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
p-malecki
approved these changes
Sep 2, 2024
kmagiera
approved these changes
Sep 2, 2024
| @@ -97,7 +101,7 @@ function transformWrapper({ filename, src, ...rest }) { | |||
| } | |||
| } | |||
|
|
|||
| return transform({ filename, src, ...rest }); | |||
| return transform({ filename, src, options, plugins }); | |||
There was a problem hiding this comment.
why this change here? I actually fixed one issue in another transformer a while ago that was assuming only three elements in that object exists while plugins was added afterwards to the specification. Given we don't use all of them it'd be more future proof to have the ellipsis here
There was a problem hiding this comment.
|
Also, can you provide the test plan here? |
p-malecki
added a commit
that referenced
this pull request
Sep 2, 2024
This PR adds a missing import in the previous PR #522 and changes `/` path separator to platform-specific in`babel_transformer.js`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're using filenames which are platform-specific to check what files should be modified. Windows uses backslashes so it wasn't ever matched.
Testing plan
Run any app on windows and check if RN IDE functionality works (inspector, etc).