-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix alternative xcode paths #542
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Please address inline comments prior to merging
|
||
### -sec-num- Configureing Alternative Xcode Versions | ||
|
||
If you are using alternative Xcode version ( e.g. xcode-beta, "xcodes" ) IDE will only work if xcode-select points to the correct directory to set it up run: `xcode-select --switch ${PathToYourXCode}/Contents/Developer` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we add link to xcodes here such that it is clear for people to understand what we refer to here in case they don't know what they use.
Also: have you tried xcodes here? It seems like it has select
command so I'd expect that it sets the value with xcode-select, otherwise building swift/xcode projects from command line wouldn't work? Regardless of that I think we can keep this in the instruction, but it'd be good to know whether we should expect this to work when someone is using xcodes or not
if (Platform.OS === "macos") { | ||
const { stdout } = await exec("xcode-select", ["-p"]); | ||
const DYLD_FRAMEWORK_PATH = path.join(stdout, "Library", "PrivateFrameworks"); | ||
simControllerBinaryEnv = { DYLD_FRAMEWORK_PATH }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we add some logging here, would be good for troubleshooting in case xcode-select prints out some trash data
This PR allows non standard xcode setups.
How to test:
xcode-select --switch ${PathToYourXCode}/Contents/Developer