Redirect logs/uncaught errors from webview to the main extension logger #621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
kmagiera
changed the title
jakub-gonet
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a mechanism for redirecting logs and unhandled error from webview to the main extension.
The reason for this change is that we can see potential issues and logs in a unified log output that we create for the extension context. This way we provide better visibility of errors that happen in the webview. Without this change, we'd always need to check both the extension log output, and the vscode devtools panel. With this change, having everything in a single output is specifically helpful when receiving logs from the users, as we no longer need to ask them to check devtools console and can focus on a single log file they need to check or send as a part of the report.
How Has This Been Tested:
Add log statement and unhandled error to the main webview App.tsx. See that this gets included in the main log output.