Remove previous app button #659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
kmagiera
reviewed
Oct 25, 2024
|
This Portion of the regex |
kmagiera
requested changes
Oct 25, 2024
Comment on lines
+287
to
+291
| await exec( | ||
| "xcrun", | ||
| ["simctl", "--set", deviceSetLocation, "terminate", this.deviceUDID, bundleID], | ||
| { allowNonZeroExit: true } | ||
| ); |
There was a problem hiding this comment.
would likely be better to use Promise.all to await on all the commands
kmagiera
approved these changes
Oct 25, 2024
Comment on lines
301
to
305
| await Promise.all( | ||
| matches.map((bundleID) => { | ||
| return terminateApp(bundleID); | ||
| }) | ||
| ); |
There was a problem hiding this comment.
Suggested change
| await Promise.all( | |
| matches.map((bundleID) => { | |
| return terminateApp(bundleID); | |
| }) | |
| ); | |
| await Promise.all(matches.map(terminateApp)); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the "previous app button" from top left corner of the ios simulator. Before this change If the user switched workspaces without shouting down the ios simulator, the button pointing to the previous app would appear in top left corner of the application. Clicking the button would break the IDE functionality as there is no way of navigating through the simulator and the only way to recover would be to restart app process (which would still leave the button in the corner).
The solution it to terminate any open applications before launching a new one.
How Has This Been Tested: