Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MultiRoot Workspace support #663

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

filip131311
Copy link
Collaborator

@filip131311 filip131311 commented Oct 25, 2024

This PR refactors how we handle the appRoot to allow for changing it in runtime.

Additionally we enhance the Lunch Configuration View to allow the user for selecting the appRoot from the list.

How has dis been tested?

Run the mono repo with 2 application and switch between them.

Screen.Recording.2024-12-19.at.17.08.49.mov

Copy link

vercel bot commented Oct 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
radon-ide ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 19, 2024 3:40pm

@kmagiera kmagiera marked this pull request as draft October 29, 2024 08:28
filip131311 added a commit that referenced this pull request Nov 22, 2024
This PR add a possibility to reboot the reboot device, metro and
devtools processes without triggering clean build. It was previously
only possible by closing and reopening the IDE panel itself.

This also will provide necessary functionality for  #663

### How Has This Been Tested: 

- run an application and pick "Reboot IDE" option from reload dropdown
menu
kmagiera added a commit that referenced this pull request Dec 16, 2024
This PR changes a way we manage build caches. Previous approach was
dependent on current vscode workspace, which led to build caches not
being accessible when switching from working in the root of the
workspace to the root of the application (or doing the same in reverse).
The new approach saves this data in global storage, and adds a appRoot
identifier to the cache key.

This PR is a dependency for #663

### How Has This Been Tested: 

- Open a project in the root of the workspace and run some application
that is part of it in the IDE.
- Open IDE in the root of that application and see if the build cache is
loaded.
- repeat the proces in reverse
- open an application that had a build made before this change and check
if migration process works as expected

Verify that the build cache migration work:
- Build project without these changes
- Open the same project with no changes but with the new version of
extension – expect the cache hit for native build

---------

Co-authored-by: Krzysztof Magiera <krzys@swmansion.com>
@filip131311 filip131311 marked this pull request as ready for review December 19, 2024 15:41
@filip131311 filip131311 requested a review from kmagiera December 20, 2024 09:40
@filip131311 filip131311 changed the title Draft of MultiRoot Workspace support MultiRoot Workspace support Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant