-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor throttling logic for async function #668
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
filip131311
reviewed
Oct 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some inline comments
…ents case, also don't use timeout variable that got copied from basic throttle implementation
filip131311
approved these changes
Oct 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When testing Radon I encountered an issue with newly cloned repo in which the IDE would generate an excessive number of npm subprocesses. The issue turned out to be related to fingerprint library, which on some occasions can spawn at least three npm processes. The main problem though was that this problem was amplified by the fact we'd request fingerprint calculation upon the watched files update. Even though the requests were throttled, because they'd take significant time to compute, we'd end up spawning many concurrent processes. This was specifically noticeable at the moment when the project was installing node modules which generates a ton of fs events that resulted in the fingerprint calculation getting triggered.
The solution this PR is implementing is to add a new throttling mechanism for async functions. It is a non-standard mechanism hence we're introducing a new method. The new mechanism is then used to throttle async code that calculates the fingerprint.
The mechanism works by keeping the following constraints:
How Has This Been Tested: