Record user and session data properly for telemetry #748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
filip131311
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue with telemetry module that wasn't collecting user-id and session-id properly resulting in all the telemetry events being squashed under a single user and session.
The main fix for user-id reporting has already landed in the new version of telemetry package microsoft/vscode-extension-telemetry#210
We also submitted a PR that has been merged to address the session ID issue: microsoft/vscode-extension-telemetry#215
Because there's been no release since that update, we're installing a fork of telemetry module with our changes included from https://github.com/software-mansion-labs/vscode-extension-telemetry
Since the package requires a build-step, we've uploaded bundled JS files into the fork repository and install the dependency using github link.
The new version of telementy module now requires a so-called "connection string" instead of just the instrumentation key as the first argument. Because of that we're also updating the public key value.
How Has This Been Tested: