Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid invoking getAvailableXcodeSchemes on Windows #838

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

p-malecki
Copy link
Contributor

@p-malecki p-malecki commented Dec 9, 2024

This PR resolves the error Could not find Xcode project files in ... which was caused by calling the getAvailableXcodeSchemes function on Windows.

The issue was exposed in #820, where additionally findPackageManager does not provide actual package manager correctly. It probably is caused by calling getLaunchConfiguration inside findPackageManager. Therefore this PR is likely to fix also #820.

Test plan (UNTESTED):

  • Run the test apps ensuring that the error "Could not find Xcode project files in... " does not occur on a Windows.
  • Verify that the findPackageManager function correctly identifies and uses the correct package manager (Can't run with yarn installed using corepack #820) on a Windows.

Testing has not been performed yet as we currently do not have access to a functioning Windows setup.

Copy link

vercel bot commented Dec 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
radon-ide ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 9, 2024 5:59pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant