-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add themes support #874
base: main
Are you sure you want to change the base?
Add themes support #874
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello, thank you for your time.
In general I really like the changes unfortunately there are some parts of the application that lose on readability after the changes, for example lunchConfiguration:
so i believe you can find the styles for them
I also left one inline question
Thank u again and merry Christmas
packages/vscode-extension/src/webview/components/shared/IconButton.css
Outdated
Show resolved
Hide resolved
a0aecc9
to
49a999c
Compare
I'd also be in favor of supporting themes properly. The reason we decided to shift away from this approach initially was that it was difficult to control some of the theme parameters under different vscode settings. This resulted in a number of elements being difficult to use as they'd blend inproperly into elements in the background for example. One way this can be solved is be giving an option whether the IDE should use the editor theme or the built-in one. I wonder how difficult would it be to incorporate that while still relying mostly on css variables. |
@kmagiera I think that it should go quite smoothly. I'll return with an example of it. One thing that is striking in this approach is that it would hurt UX a bit, forcing users to manually switch to the default theme. You know, I mean the experience that something does not look well and then someone would report this because overlooked this option in workspace config or so. But maybe I exaggerate. |
I agree such a setting would be difficult to discover. Perhaps we should default to the editor theme and only expect the setting to be used as a fallback when the UI doesn't look good in certain theme |
49a999c
to
04a8ec9
Compare
04a8ec9
to
1ae63ae
Compare
1ae63ae
to
4f2ade6
Compare
4b6657f
to
e4fcf05
Compare
…onally add small horizontal margins in some views because input was cut off. Tested views: 1. Manage devices view and rename devices 2. Launch config modal 3. Localization modal 4. Location modal
…View` similarly to how it's done with `Input`
e4fcf05
to
0f1e2af
Compare
0f1e2af
to
7c4cda2
Compare
This pull request adds support for vscode themes
Connected (#729 (comment) , #866)
The changes add new theme based on vscode theme variables. As being aware that some themes may decrease readability, this PR adds option to use built-in themes. Built-in themes stay mostly not changed, only few additional variables that allow better customization with the new changes.
night-owl.mov
cursor-default.mov
vscode-default.mov
palenight.mov