Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add object detection (iOS) #49

Merged
merged 21 commits into from
Dec 16, 2024
Merged

feat: Add object detection (iOS) #49

merged 21 commits into from
Dec 16, 2024

Conversation

chmjkb
Copy link
Contributor

@chmjkb chmjkb commented Dec 12, 2024

Description

This PR introduces a new native and typescript api - object detection. For now, it only supports SSDLiteLarge320 model from torchvision. Given that operations such as NMS are hard/impossible to export, they were implemented in the native code of the library.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (improves or adds clarity to existing documentation)

Tested on

  • iOS
  • Android

Testing instructions

Screenshots

Related issues

Checklist

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly
  • My changes generate no new warnings

Additional notes

@chmjkb chmjkb marked this pull request as draft December 12, 2024 07:42
@chmjkb chmjkb marked this pull request as ready for review December 12, 2024 10:32
src/models/object_detection/types.ts Show resolved Hide resolved
src/models/object_detection/ObjectDetection.ts Outdated Show resolved Hide resolved
ios/RnExecutorch/utils/ImageProcessor.mm Outdated Show resolved Hide resolved
ios/RnExecutorch/utils/ImageProcessor.mm Outdated Show resolved Hide resolved
ios/RnExecutorch/ObjectDetection.mm Outdated Show resolved Hide resolved
ios/RnExecutorch/utils/Constants.mm Outdated Show resolved Hide resolved
@chmjkb chmjkb requested a review from mkopcins December 13, 2024 13:14
ios/RnExecutorch/ObjectDetection.mm Outdated Show resolved Hide resolved
ios/RnExecutorch/ObjectDetection.mm Outdated Show resolved Hide resolved
ios/RnExecutorch/models/StyleTransferModel.mm Outdated Show resolved Hide resolved
ios/RnExecutorch/models/StyleTransferModel.mm Outdated Show resolved Hide resolved
ios/RnExecutorch/models/StyleTransferModel.mm Outdated Show resolved Hide resolved
src/models/object_detection/ObjectDetection.ts Outdated Show resolved Hide resolved
src/models/object_detection/ObjectDetection.ts Outdated Show resolved Hide resolved
src/models/object_detection/ObjectDetection.ts Outdated Show resolved Hide resolved
src/models/object_detection/ObjectDetection.ts Outdated Show resolved Hide resolved
src/models/object_detection/ObjectDetection.ts Outdated Show resolved Hide resolved
@chmjkb chmjkb force-pushed the @chmjkb/object-detection branch from 389b7cd to 0d631a6 Compare December 16, 2024 08:57
@chmjkb chmjkb requested a review from mkopcins December 16, 2024 10:08
@chmjkb chmjkb changed the base branch from main to @norbertklockiewicz/style-transfer-implementation December 16, 2024 12:26
Base automatically changed from @norbertklockiewicz/style-transfer-implementation to main December 16, 2024 12:55
@chmjkb chmjkb force-pushed the @chmjkb/object-detection branch 2 times, most recently from 7ebeef0 to fd86938 Compare December 16, 2024 13:19
@mkopcins mkopcins force-pushed the @chmjkb/object-detection branch from fd86938 to fda3501 Compare December 16, 2024 13:32
@chmjkb chmjkb merged commit e6593fd into main Dec 16, 2024
2 checks passed
@chmjkb chmjkb deleted the @chmjkb/object-detection branch December 16, 2024 13:35
chmjkb added a commit that referenced this pull request Dec 17, 2024
## Description
This PR introduces a new native and typescript api - object detection.
For now, it only supports SSDLiteLarge320 model from torchvision. Given
that operations such as NMS are hard/impossible to export, they were
implemented in the native code of the library.

### Type of change
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] Documentation update (improves or adds clarity to existing
documentation)

### Tested on
- [x] iOS
- [ ] Android

### Testing instructions
<!-- Provide step-by-step instructions on how to test your changes.
Include setup details if necessary. -->

### Screenshots
<!-- Add screenshots here, if applicable -->

### Related issues
<!-- Link related issues here using #issue-number -->

### Checklist
- [ ] I have performed a self-review of my code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have updated the documentation accordingly
- [ ] My changes generate no new warnings

### Additional notes
<!-- Include any additional information, assumptions, or context that
reviewers might need to understand this PR. -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants