ReanimatedSwipable Delayed #3147
Labels
Comments
|
Hey! 👋 The issue doesn't seem to contain a minimal reproduction. Could you provide a snack or a link to a GitHub repository under your username that reproduces the problem? |
github-actions
bot
added
Missing repro
Platform: iOS
latekvo
added
Can repro
latekvo
added a commit
that referenced
this issue
Oct 17, 2024
## Description This PR applies multiple bug fixes and improvements to the `ReanimatedSwipeable` ### Changes: - Fix reversed swipe direction being supplied to `open` and `willOpen` callbacks. - Fix `startDrag` callbacks receiving invalid `direction` when opening swipeable. - Fix unpredictable swipe direction being supplied to `close` and `willClose` callbacks. - Fix `onSwipeableWillClose` and `onSwipeableClose` callbacks sometimes being called on open. - Fix `progress` value skipping last `10%` of it's range and having a delay relative to the `translation`. closes #3147 ## Test plan Will create an example showcasing outputs of all the affected callbacks, work in progress.
|
@latekvo sorry for the late reply, this solved my issue! Is this going to be released soon? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
Tried upgrading from
SwipeabletoReanimatedSwipablebut had to rollback.For some reason the
progressvalue onReanimatedSwipableupdates delayed as to what happened on the UI, the swipeable is already open but the progess.value, onSwipeableOpen, etc all fire 1-2 seconds after. This was not an issue withSwipeableSteps to reproduce
Test side-by-side a Swipeable and ReanimatedSwipable
Snack or a link to a repository
N/A
Gesture Handler version
2.20.0
React Native version
0.75.4
Platforms
iOS
JavaScript runtime
Hermes
Workflow
Expo bare workflow
Architecture
Paper (Old Architecture)
Build type
Debug mode
Device
iOS simulator
Device model
iPhone 16 Pro Max - iOS 18
Acknowledgements
Yes
The text was updated successfully, but these errors were encountered: