Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate RNGestureHandlerEnabledRootView #1605

Merged
merged 1 commit into from
Aug 27, 2021

Conversation

jakub-gonet
Copy link
Member

No description provided.

@jakub-gonet jakub-gonet self-assigned this Aug 27, 2021
@jakub-gonet jakub-gonet merged commit 27e61dc into master Aug 27, 2021
@jakub-gonet jakub-gonet deleted the jgonet/deprecate-RNGestureHandlerRootView branch August 27, 2021 09:45
#### Updating `MainActivity.java`

:::caution
From version 2.0.0 this step isn't needed. You should use

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this reanimated v2?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, the not-yet-released RNGH 2.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But thanks for reminding us that we should version our docs.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, is their rc candidate to test v2?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not yet, we don't know if we want to do rc release. You can pack master if you want to, though.

fluiddot pushed a commit to wordpress-mobile/react-native-gesture-handler that referenced this pull request Feb 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants