Change absolute position to be relative to the window instead of the screen #1812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmagiera
approved these changes
Jan 10, 2022
j-piasecki
added a commit
that referenced
this pull request
Mar 26, 2024
…roid (#2826) ## Description In #1812 I changed how absolute position is calculated to be relative to the window instead of the screen, but there were two things wrong with it: - It used [getWindowVisibleDisplayFrame](https://developer.android.com/reference/android/view/View#getWindowVisibleDisplayFrame(android.graphics.Rect)) which `tells you the available area where content can be placed and remain visible to users`. This was always taking status bar height into account, even if the app could be drawn behind it. - It was calling this method on the `decorView`, which is drawn under system bars anyway This PR changes it to use `contentView` of the current activity and [getLocationOnScreen](https://developer.android.com/reference/android/view/View#getLocationOnScreen(int[])) which `gets the coordinates of this view in the coordinate space of the device screen, irrespective of system decorations and whether the system is in multi-window mode`. In a nutshell, after this PR the absolute position will take into account whether the app is displayed behind the status bar. ## Test plan Tested on the example app: https://github.com/software-mansion/react-native-gesture-handler/assets/21055725/c3230a2d-7bba-483b-b160-1c9fb32b0da1 https://github.com/software-mansion/react-native-gesture-handler/assets/21055725/701d9fa0-0c9f-4126-af58-f80c6a0a6526
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes how absolute position of events is calculated to be relative to the window instead of the screen. This makes it consistent with iOS and takes status bar and split-screen mode into account when calculating it.
Test plan
Tested on the Example app