Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nested pressable's event propagation. #2981

Merged
merged 75 commits into from
Jul 25, 2024
Merged

Fix nested pressable's event propagation. #2981

merged 75 commits into from
Jul 25, 2024

Commits on Jul 4, 2024

  1. add nested pressables example

    @latekvo
    latekvo committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    b911447 View commit details
    Browse the repository at this point in the history

  2. merge 'main'

    @latekvo
    latekvo committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    cfc8570 View commit details
    Browse the repository at this point in the history

  3. revert merge artifact

    @latekvo
    latekvo committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    c0af5ec View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2024

  1. fix touch propagation for android

    @latekvo
    latekvo committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    40b7691 View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2024

  1. Merge remote-tracking branch 'origin/main' into @latekvo/fix-pressabl… 

    …e-event-propagation
    @latekvo
    latekvo committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    bc92023 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into @latekvo/fix-pressable-event-propagation

    @latekvo
    latekvo authored Jul 9, 2024
    Configuration menu
    Copy the full SHA
    c51602f View commit details
    Browse the repository at this point in the history

  3. make use of view built in button to fix propagation on IOS

    @latekvo
    latekvo committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    7326626 View commit details
    Browse the repository at this point in the history

  4. remove console logs

    @latekvo
    latekvo committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    9c5dc56 View commit details
    Browse the repository at this point in the history

  5. remove unnecessary function call

    @latekvo
    latekvo committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    23b93ed View commit details
    Browse the repository at this point in the history

  6. add hitslop to new view api usage

    @latekvo
    latekvo committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    f2e6f77 View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2024

  1. add support for new events - create and use needed adapters

    @latekvo
    latekvo committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    24c1cfc View commit details
    Browse the repository at this point in the history

  2. change function names and remove unnecessary exports

    @latekvo
    latekvo committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    29a5b04 View commit details
    Browse the repository at this point in the history

  3. simplify function flow

    @latekvo
    latekvo committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    3df9cdd View commit details
    Browse the repository at this point in the history

  4. improve variable names

    @latekvo
    latekvo committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    c16bbfd View commit details
    Browse the repository at this point in the history

  5. re-enable native-event related conditions

    @latekvo
    latekvo committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    acea81d View commit details
    Browse the repository at this point in the history

  6. rename related type to a more sensible name

    @latekvo
    latekvo committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    21b8872 View commit details
    Browse the repository at this point in the history

  7. unify types and remove unnecessary type

    @latekvo
    latekvo committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    20d7981 View commit details
    Browse the repository at this point in the history

  8. replace unnecessary function

    @latekvo
    latekvo committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    3c448ad View commit details
    Browse the repository at this point in the history

  9. simplify Native View Event adapter

    @latekvo
    latekvo committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    67f2a7f View commit details
    Browse the repository at this point in the history

  10. fix recursive errors

    @latekvo
    latekvo committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    0ca146d View commit details
    Browse the repository at this point in the history

  11. clear up variable name

    @latekvo
    latekvo committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    36f4788 View commit details
    Browse the repository at this point in the history

  12. remove unnecessary stopPropagation function usage

    @latekvo
    latekvo committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    509cc1c View commit details
    Browse the repository at this point in the history

  13. move away from using view touch events

    @latekvo
    latekvo committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    384f5c9 View commit details
    Browse the repository at this point in the history

  14. make android example functional again by using Native Gesture for pro… 

    …pagation checking
    @latekvo
    latekvo committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    bdfed1f View commit details
    Browse the repository at this point in the history

  15. fix manual gesture breaking other gestures and write logic for ios ev… 

    …ent handling
    @latekvo
    latekvo committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    ceda231 View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2024

  1. fix long press breaking state flow by removing state-changing gesture… 

    …s other than long press
    @latekvo
    latekvo committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    bb27ff7 View commit details
    Browse the repository at this point in the history

  2. correct state flow with correct callback calling on ios and android

    @latekvo
    latekvo committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    6b49233 View commit details
    Browse the repository at this point in the history

  3. fix functional prop setting on ios

    @latekvo
    latekvo committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    ce1a4d9 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into @latekvo/fix-pressable-event-propagation

    @latekvo
    latekvo authored Jul 11, 2024
    Configuration menu
    Copy the full SHA
    7977e14 View commit details
    Browse the repository at this point in the history

  5. remove debug messages

    @latekvo
    latekvo committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    b113d32 View commit details
    Browse the repository at this point in the history

  6. fix double onPressIn calls

    @latekvo
    latekvo committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    a514de8 View commit details
    Browse the repository at this point in the history

  7. fix web propagation issue

    @latekvo
    latekvo committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    1b245fa View commit details
    Browse the repository at this point in the history

  8. update nested example name

    @latekvo
    latekvo committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    e74b1de View commit details
    Browse the repository at this point in the history

  9. fix all gestures randomly being cancelled

    @latekvo
    latekvo committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    91d80a2 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2024

  1. remove unnecessary return potentially improving ios responsiveness

    @latekvo
    latekvo committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    006c347 View commit details
    Browse the repository at this point in the history

  2. fix press in being triggered too late on ios outside of native scroll… 

    … element
    @latekvo
    latekvo committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    a1929fc View commit details
    Browse the repository at this point in the history

  3. correct major typo in nested example

    @latekvo
    latekvo committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    da5a507 View commit details
    Browse the repository at this point in the history

  4. remove unnecessary lorem ipsum

    @latekvo
    latekvo committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    436a2ea View commit details
    Browse the repository at this point in the history

  5. simplify and improve styles in nested example

    @latekvo
    latekvo committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    eda4915 View commit details
    Browse the repository at this point in the history

  6. make all comments upper case

    @latekvo
    latekvo committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    fe80f48 View commit details
    Browse the repository at this point in the history

  7. make all comments uppercase

    @latekvo
    latekvo committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    9dd8408 View commit details
    Browse the repository at this point in the history

  8. clarify and remove comments

    @latekvo
    latekvo committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    ae687f4 View commit details
    Browse the repository at this point in the history

  9. remove unnecessary instances of propagationGreenLight

    @latekvo
    latekvo committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    028a18b View commit details
    Browse the repository at this point in the history

  10. fix long press canceling when outside on web

    @latekvo
    latekvo committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    5fe2695 View commit details
    Browse the repository at this point in the history

  11. change mentions in comments iOS to proper casing

    @latekvo
    latekvo committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    8bb2069 View commit details
    Browse the repository at this point in the history

  12. fix hover out not working on web

    @latekvo
    latekvo committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    a996fbd View commit details
    Browse the repository at this point in the history

  13. fix invalid propagation checks on ios

    @latekvo
    latekvo committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    41eaf75 View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2024

  1. remove unusual triggerings of nested pressables

    @latekvo
    latekvo committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    16e5eb1 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into @latekvo/fix-pressable-event-propagation

    @latekvo
    latekvo authored Jul 15, 2024
    Configuration menu
    Copy the full SHA
    26d7683 View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2024

  1. fix incorrect pressOut calls

    @latekvo
    latekvo committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    bb7c3ea View commit details
    Browse the repository at this point in the history

  2. fix onPress not being called

    @latekvo
    latekvo committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    6891168 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into @latekvo/fix-pressable-event-propagation

    @latekvo
    latekvo authored Jul 16, 2024
    Configuration menu
    Copy the full SHA
    6ed3f46 View commit details
    Browse the repository at this point in the history

  4. move awaiting event setting to fix lack of onPressIn on ios

    @latekvo
    latekvo committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    e215258 View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2024

  1. fix incorrect async concurrency checks resulting in missing callback … 

    …calls
    @latekvo
    latekvo committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    c5e1903 View commit details
    Browse the repository at this point in the history

  2. fix false-positive propagation checks when lightly tapping nested pre… 

    …ssables
    @latekvo
    latekvo committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    e180e85 View commit details
    Browse the repository at this point in the history

  3. add test ids to all nested pressables for ease of testing

    @latekvo
    latekvo committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    23fd745 View commit details
    Browse the repository at this point in the history

  4. fix propagationGreenLight not being set on ios when native button is … 

    …activated after measurement succesfully passed
    @latekvo
    latekvo committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    5d4cbfc View commit details
    Browse the repository at this point in the history

  5. remove unnecessary memo dependancy

    @latekvo
    latekvo committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    05d51ef View commit details
    Browse the repository at this point in the history

  6. remove unnecessary green light disablement

    @latekvo
    latekvo committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    e307931 View commit details
    Browse the repository at this point in the history

  7. change from gesture based to touch based long press

    @latekvo
    latekvo committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    2616c6e View commit details
    Browse the repository at this point in the history

  8. add long press timeout clearing

    @latekvo
    latekvo committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    94f62dd View commit details
    Browse the repository at this point in the history

  9. add clarification comments to long press gesture

    @latekvo
    latekvo committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    e2302c0 View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2024

  1. add fix for no-scroll no-nesting ios case

    @latekvo
    latekvo committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    884ebcf View commit details
    Browse the repository at this point in the history

  2. fix invalid detection of native gesture as the first gesture

    @latekvo
    latekvo committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    599f370 View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2024

  1. clean and remove comments

    @latekvo
    latekvo committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    0b2749d View commit details
    Browse the repository at this point in the history

  2. flatten if-else trees and remove unused flag

    @latekvo
    latekvo committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    1514a03 View commit details
    Browse the repository at this point in the history

  3. rename variable as per suggestion

    @latekvo
    latekvo committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    3ee32aa View commit details
    Browse the repository at this point in the history

  4. replace event payload comment for a clearer one

    @latekvo
    latekvo committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    6f0539d View commit details
    Browse the repository at this point in the history

  5. update unclear comment

    @latekvo
    latekvo committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    3306f1b View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2024

  1. change ambiguous ref name

    @latekvo
    latekvo committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    be72b2f View commit details
    Browse the repository at this point in the history

  2. remove unnecessary utility function

    @latekvo
    latekvo committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    6ef4716 View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2024

  1. improve example design

    @latekvo
    latekvo committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    8f3c4a3 View commit details
    Browse the repository at this point in the history

  2. change variable name as per suggestion

    @latekvo
    latekvo committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    6a21865 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2024

  1. replace inconsistant if statements

    @latekvo
    latekvo committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    64e9d50 View commit details
    Browse the repository at this point in the history

  2. rename variable as per suggestion

    @latekvo
    latekvo committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    c7b1b84 View commit details
    Browse the repository at this point in the history