Fix scroll view handler state change events #2985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-piasecki
reviewed
Jul 10, 2024
j-piasecki
reviewed
Jul 11, 2024
j-piasecki
reviewed
Jul 18, 2024
apple/RNGestureHandler.mm
Outdated
| return NO; | ||
| } | ||
|
|
||
| - (UIScrollView *)retrieveScrollView:(UIView *)view |
There was a problem hiding this comment.
I believe this line breaks macOS compilation. You should be able to replace UIView with RNGHUIView.
You will also need to do something about UIScrollView which will not exist on macOS. You should be able to use the TARGET_OS_OSX flag and conditionally replace it with NSScrollView.
Co-authored-by: Jakub Piasecki <jakub.piasecki@swmansion.com>
Co-authored-by: Jakub Piasecki <jakub.piasecki@swmansion.com>
j-piasecki
reviewed
Jul 22, 2024
j-piasecki
approved these changes
Aug 5, 2024
j-piasecki
added a commit
that referenced
this pull request
Aug 7, 2024
## Description In #2985 some changes were made regarding handling of ScrollViews by the native handler. I have no idea how the build passed on the PR itself but a type only available on iOS was used which causes macOS not to build. This PR cleans it up. ## Test plan Build macOS example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Regarding this issue, this PR fixes the events that are sent from iOS whenever the state change occurs in a RCTScrollView.
Test plan
Tested on simulator and real device.