Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[macOS] Fix handlers not responding after opening context menu #3008

Merged
merged 3 commits into from
Jul 26, 2024
Merged

[macOS] Fix handlers not responding after opening context menu #3008

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7b42fa0
Fix right click
m-bert Jul 26, 2024
fc8e9ec
Merge branch 'main' into @mbert/fix-right-click-macos
m-bert Jul 26, 2024
085ec03
Merge branch 'main' into @mbert/fix-right-click-macos
m-bert Jul 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions apple/RNRootViewGestureRecognizer.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,11 @@ - (void)rightMouseDown:(NSEvent *)event
{
[super rightMouseDown:event];
[self interactionsBegan:[NSSet setWithObject:event] withEvent:event];

// This line fixes issue in which handlers couldn't react to mouse clicks after right click.
// Right click opens context menu, which prevents RootView from receiving rightMouseUp. This leads
// to a situation where RootView is left in Possible state, instead of Failed, thus blocking other handlers.
self.state = NSGestureRecognizerStateFailed;
}

- (void)mouseDragged:(NSEvent *)event
Expand Down
Loading