Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[macOS] Add ManualGestureHandler #3018

Merged
merged 8 commits into from
Aug 2, 2024
Merged

[macOS] Add ManualGestureHandler #3018

merged 8 commits into from
Aug 2, 2024

Conversation

m-bert
Copy link
Contributor

@m-bert m-bert commented Jul 30, 2024

Description

This PR adds ManualGestureHandler on macOS.

Test plan

Tested on example App.

@m-bert m-bert marked this pull request as ready for review July 30, 2024 14:16
@m-bert m-bert requested a review from j-piasecki July 30, 2024 14:16
{
[_gestureHandler setCurrentPointerType:event];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we need this?

Copy link
Contributor Author

@m-bert m-bert Jul 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct me if I'm wrong, but it is still present in touchesBegan, just git shows this diff in a weird way

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I see. It makes sense to split that between implementations.

@m-bert m-bert requested a review from j-piasecki July 31, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants