[macOS] Add FlingGestureHandler
#3028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-piasecki
reviewed
Aug 19, 2024
latekvo
reviewed
Aug 20, 2024
latekvo
reviewed
Aug 21, 2024
apple/Handlers/RNFlingHandler.m
Outdated
Comment on lines
195
to
213
| for (int i = 0; i < directionsSize; ++i) { | ||
| if ([self getAlignment:diagonalDirections[i] | ||
| withMinimalAlignmentCosine:diagonalDeviationCosine | ||
| withVelocityVector:velocityVector]) { | ||
| isAligned = YES; | ||
| break; | ||
| } | ||
| } | ||
|
|
||
| if (!isAligned) { | ||
| for (int i = 0; i < directionsSize; ++i) { | ||
| if ([self getAlignment:axialDirections[i] | ||
| withMinimalAlignmentCosine:axialDeviationCosine | ||
| withVelocityVector:velocityVector]) { | ||
| isAligned = YES; | ||
| break; | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Just an opinion, but I think it'd be preferable to check axialDirections first.
They are more likely to occur and these iterations are not all that cheap
There was a problem hiding this comment.
I agree, done in 6406cd0
latekvo
approved these changes
Aug 21, 2024
There was a problem hiding this comment.
Looking good, just make sure these are resolved before merging:
#3028 (comment)
#3028 (comment)
Those comments require response from @j-piasecki, so I believe he will address them when reviewing this PR 😅 |
This reverts commit e09f18e.
…react-native-gesture-handler into @mbert/add-fling-macos
j-piasecki
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds
FlingGestureHandleronmacOS. From now, all handlers, exceptForceTouchGestureHandler, are available on this platform 🥳Test plan
Tested on newly added example.