Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Add Swipe & Scroll guide #3254

Merged
merged 3 commits into from
Dec 2, 2024
Merged

[docs] Add Swipe & Scroll guide #3254

merged 3 commits into from
Dec 2, 2024

Conversation

m-bert
Copy link
Contributor

@m-bert m-bert commented Dec 2, 2024

Description

At the beginning of new web implementation Swipeable component was blocking scroll on web. We did fix it by adding touch-action: pan-y; as a property to our handlers, and making it default in Pan used under the hood of Swipeable.

However, some of our users prefer to create their own versions of Swipeable - that's where they encounter this issue.

This PR adds guide section about fixing this problem.

It also changes font size of code inside headers such that it is no longer ridiculously small.

Test plan

Run docs

Copy link
Contributor

@patrycjakalinska patrycjakalinska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good fix with small font! ✨ The guide sounds good, one thing I'd do is to change title to more describing like Custom swipeable components inside ScrollView (web) and remove subtitle.

Also, I understand its placement (under Guides section) but it's kinda short for separate page. I'd be perfect if there'll be a better place for it, but I'm not pushing as for now it's pretty acceptable.

Copy link
Contributor

@patrycjakalinska patrycjakalinska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@m-bert m-bert merged commit 39caf79 into main Dec 2, 2024
1 check passed
@m-bert m-bert deleted the @mbert/add-swipe-scroll-guide branch December 2, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants