Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some changes in #3740 required follow up.
Tap
Turns out that we can leave
triggerActioninreset(thank you apple for transparent docs that clearly describe what changed between 18.5 and 26 ❤️).It also seems that double
onFinalizeissue is fixed on 26.Fling
Removing
[self triggerAction]fromresetbroke things on old iOS. Unfortunately now swiping in different direction does not result in callingonFinalize- this should be handled bytriggerActioninreset, but now by default recognizers inresethavePossiblestate (once again, thank you apple 😄). To fix that we will probably have to rewrite fling to custom logic.LongPress
LongPresswas missing ontriggerActioncall that sendsfail.Pan
In
Pan, I've movedtriggerActioncalls fromtouches*methods tointeractions*methods.Test plan
Tested on basic-example and the following code: