fix: remove explicit folly version #3416
Merged
+1
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomekzaw
approved these changes
Jul 27, 2022
piaskowyk
approved these changes
Jul 28, 2022
piaskowyk
pushed a commit
that referenced
this pull request
Jul 28, 2022
As a version of folly can change between versions of React-native we need to remove an explicit version of `folly_version` from our libraries to let RN infer the correct version. Change based on th3rdwave/react-native-safe-area-context@eb111ff Removed explicit folly version from RNReanimated.podspec <!-- Here you can add screenshots / GIFs documenting your change. You can add before / after section if you're changing some behavior. --> Build FabricExample/ - [ ] Ensured that CI passes
fluiddot
pushed a commit
to wordpress-mobile/react-native-reanimated
that referenced
this pull request
Jun 5, 2023
## Description As a version of folly can change between versions of React-native we need to remove an explicit version of `folly_version` from our libraries to let RN infer the correct version. Change based on th3rdwave/react-native-safe-area-context@eb111ff ## Changes Removed explicit folly version from RNReanimated.podspec <!-- ## Screenshots / GIFs Here you can add screenshots / GIFs documenting your change. You can add before / after section if you're changing some behavior. ### Before ### After --> ## Test code and steps to reproduce Build FabricExample/ ## Checklist - [ ] Ensured that CI passes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As a version of folly can change between versions of React-native we need to remove an explicit version of
folly_versionfrom our libraries to let RN infer the correct version.Change based on th3rdwave/react-native-safe-area-context@eb111ff
Changes
Removed explicit folly version from RNReanimated.podspec
Test code and steps to reproduce
Build FabricExample/
Checklist