Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bumped gesture-handler and screens dependencies #3468

Merged
merged 4 commits into from
Aug 16, 2022
Merged

Bumped gesture-handler and screens dependencies #3468

merged 4 commits into from
Aug 16, 2022

Conversation

Kwasow
Copy link
Contributor

@Kwasow Kwasow commented Aug 12, 2022

Description

react-native-screens: software-mansion/react-native-screens#568e588817538740dff23a3590748614d4c346e3 => 3.15.0

react-native-gesture-handler: 2.4.2 => 2.5.0

Checklist

  • Included code example that can be used to test this change
  • Updated TS types
  • Added TS types tests
  • Added unit / integration tests
  • Updated documentation
  • Ensured that CI passes

tomekzaw
tomekzaw approved these changes Aug 12, 2022
View reviewed changes
Copy link
Member

@tomekzaw tomekzaw left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO:

  • Bump dependencies in Example app
  • Add package.json in CI paths

piaskowyk
piaskowyk approved these changes Aug 12, 2022
View reviewed changes
Copy link
Member

@piaskowyk piaskowyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@piaskowyk
Copy link
Member

What we can do with broken CI?
Android NDK: ERROR:/home/runner/work/react-native-reanimated/react-native-reanimated/FabricExample/node_modules/react-native-gesture-handler/android/src/main/jni/Android.mk:fb: LOCAL_SRC_FILES points to a missing file
https://github.com/software-mansion/react-native-reanimated/runs/7808165108?check_suite_focus=true

@piaskowyk
Copy link
Member

I tested it locally, and it worked for me.

@Kwasow
Copy link
Contributor Author

Kwasow commented Aug 16, 2022

I think the CI might be fixed by #3456

@Kwasow Kwasow merged commit 3691d81 into main Aug 16, 2022
@Kwasow Kwasow deleted the @kwasow/rnScreensFix branch August 16, 2022 05:42
@piaskowyk piaskowyk restored the @kwasow/rnScreensFix branch August 16, 2022 07:10
@piaskowyk piaskowyk deleted the @kwasow/rnScreensFix branch August 16, 2022 09:18
piaskowyk pushed a commit that referenced this pull request Aug 17, 2022
@Kwasow @piaskowyk
Bumped gesture-handler and screens dependencies (#3468)
98c628a 
* Bumped react-native-screens to 3.15.0
* Bumped react-native-gesture-handler to 2.5.0
* Updated workflows to include changes to example apps
fluiddot pushed a commit to wordpress-mobile/react-native-reanimated that referenced this pull request Jun 5, 2023
@Kwasow @fluiddot
Bumped gesture-handler and screens dependencies (software-mansion#3468)
8d6b13a 
* Bumped react-native-screens to 3.15.0
* Bumped react-native-gesture-handler to 2.5.0
* Updated workflows to include changes to example apps
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piaskowyk piaskowyk piaskowyk approved these changes

@tomekzaw tomekzaw tomekzaw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kwasow @piaskowyk @tomekzaw