Fix Android crash when reloading JSC runtime #3469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukmccall
approved these changes
Aug 16, 2022
|
@piaskowyk Can we get this fix in 2.10 release? |
piaskowyk
approved these changes
Aug 16, 2022
|
Was this incorporated into 2.10.0? I think yes? But I don't see if in the changelog or in the compare feature: 2.9.1...2.10.0 This crash is killing us. |
|
This PR was cherry-picked for 2.10.0 so the crash should be already fixed: https://github.com/software-mansion/react-native-reanimated/blob/2.10.0/android/src/main/cpp/NativeProxy.cpp#L42-L45 |
|
Confirming the crash appears to be resolved now. |
kyunkakata
added a commit
to kyunkakata/react-native-reanimated
that referenced
this pull request
Feb 7, 2023
fluiddot
pushed a commit
to wordpress-mobile/react-native-reanimated
that referenced
this pull request
Jun 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3351.
Changes
Test code and steps to reproduce
Checklist