fix(jestUtils): use global expect
if available
#3583
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Doing
require('expect')
(orrequire('@jest/globals')
) is not needed unless Jest is configured withinjectGlobals: false
. So just using the global means less work.We probably don't even need the fallback to
require('expect')
as@jest/globals
will exist in any setup whereexpect
is not a global.Closes #3559
Fixes #3553
Fixes #3215
Changes
Check for global
expect
before trying to load it throughnode_modules
.Test code and steps to reproduce
This now works correctly for Jest 28.
Checklist