Fix V8 integration for Reanimated V3 #3736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
…r/react-native-reanimated into capezzb/fix-v8-with-reanimatedv3
piaskowyk
approved these changes
Nov 4, 2022
tomekzaw
requested changes
Nov 4, 2022
| - 'Example/package.json' | ||
| push: | ||
| branches: | ||
| - main |
There was a problem hiding this comment.
Don't forget to change it to Reanimated2 when cherry-picking this PR.
tomekzaw
approved these changes
Nov 4, 2022
piaskowyk
pushed a commit
that referenced
this pull request
Nov 7, 2022
This PR is an attempt to fix V8 integration with Reanimated V3. Current issue: ``` react-native/node_modules/react-native-reanimated/Common/cpp/ReanimatedRuntime/ReanimatedRuntime.cpp:40:38: error: use of undeclared identifier 'runtime_' ``` Updated `ReanimatedRuntime::make` to accept a new parameter `jsi::Runtime *runtime`, which is necessary to initialize V8 - Create a new RN app - Setup the app to have V8 as engine - Enable the new architecture (might not be necessary) - Build the Android app - Confirm the app builds and runs fine with this change <!-- Please include code that can be used to test this change and short description how this example should work. This snippet should be as minimal as possible and ready to be pasted into editor (don't exclude exports or remove "not important" parts of reproduction example) --> - [ ] Included code example that can be used to test this change - [ ] Updated TS types - [ ] Added TS types tests - [ ] Added unit / integration tests - [ ] Updated documentation - [ ] Ensured that CI passes
fluiddot
pushed a commit
to wordpress-mobile/react-native-reanimated
that referenced
this pull request
Jun 5, 2023
## Description This PR is an attempt to fix V8 integration with Reanimated V3. Current issue: ``` react-native/node_modules/react-native-reanimated/Common/cpp/ReanimatedRuntime/ReanimatedRuntime.cpp:40:38: error: use of undeclared identifier 'runtime_' ``` ## Changes Updated `ReanimatedRuntime::make` to accept a new parameter `jsi::Runtime *runtime`, which is necessary to initialize V8 ## Test code and steps to reproduce - Create a new RN app - Setup the app to have V8 as engine - Enable the new architecture (might not be necessary) - Build the Android app - Confirm the app builds and runs fine with this change <!-- Please include code that can be used to test this change and short description how this example should work. This snippet should be as minimal as possible and ready to be pasted into editor (don't exclude exports or remove "not important" parts of reproduction example) --> ## Checklist - [ ] Included code example that can be used to test this change - [ ] Updated TS types - [ ] Added TS types tests - [ ] Added unit / integration tests - [ ] Updated documentation - [ ] Ensured that CI passes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is an attempt to fix V8 integration with Reanimated V3. Current issue:
Changes
Updated
ReanimatedRuntime::maketo accept a new parameterjsi::Runtime *runtime, which is necessary to initialize V8Test code and steps to reproduce
Checklist