Fix search modal styling #3744
Merged
Fix search modal styling #3744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kacperkapusciak
approved these changes
Nov 7, 2022
j-piasecki
added a commit
to software-mansion/react-native-gesture-handler
that referenced
this pull request
Nov 7, 2022
## Description This PR applies the same changes as software-mansion/react-native-reanimated#3744, thanks @blazejkustra! Before: <img width="569" alt="Screenshot 2022-11-07 at 09 18 06" src="https://user-images.githubusercontent.com/21055725/200260032-65bb1b5d-4b7f-4c21-a914-6ebf434d0cf9.png"> After: <img width="569" alt="Screenshot 2022-11-07 at 09 17 40" src="https://user-images.githubusercontent.com/21055725/200260056-648c39bb-6fb7-46bc-b04c-65a98c002d3e.png">
piaskowyk
pushed a commit
that referenced
this pull request
Nov 7, 2022
Search modal has too big margin. It is due to the fact that html element `section` was styled in `custom.css` file that should style only the landing page, therefore search modal was styled by mistake.
fluiddot
pushed a commit
to wordpress-mobile/react-native-reanimated
that referenced
this pull request
Jun 5, 2023
Search modal has too big margin. It is due to the fact that html element `section` was styled in `custom.css` file that should style only the landing page, therefore search modal was styled by mistake.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Search modal has too big margin. It is due to the fact that html element
sectionwas styled incustom.cssfile that should style only the landing page, therefore serach modal was styled by mistake.before:
after:
