Batch update props JSI calls #4503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @tomekzaw, is it safe to cherry-pick and patch current version? We lack performance of reanimated and trying to improve it, so I'm willing to test this change. |
|
Hello @Rag0n, I wouldn't say it's production ready but hey, it works, and it's faster. I had to prioritize other issues but once we release 3.3.0 I'll get right back to this PR. edit: I've merged current main so you can even install Reanimated from this branch with |
piaskowyk
reviewed
Jun 19, 2023
android/src/main/java/com/swmansion/reanimated/NodesManager.java
Outdated
Show resolved
Hide resolved
piaskowyk
approved these changes
Jun 21, 2023
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 21, 2023
<!-- Thanks for submitting a pull request! We appreciate you spending the time to work on these changes. Please follow the template so that the reviewers can easily understand what the code changes affect. --> ## Summary This PR fixes a regression introduced in #4503. If there was more than one view descriptor, `queueMicrotask(this.flush)` would never be called. ## Test plan ChessboardExample.tsx
57 tasks
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4495.
Test plan