Add setNativeProps helper function on UI runtime
#4595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomekzaw
changed the title
setNativeProps on Paper and FabricsetNativeProps helper function on UI runtime
57 tasks
piaskowyk
reviewed
Aug 3, 2023
WoLewicki
reviewed
Aug 4, 2023
tomekzaw
force-pushed
the
@tomekzaw/set-native-props
branch
from
e20a7be
to
458eb37
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 12, 2023
# Motivation This PR documents the new `setNativeProps` function added in #4595 https://github.com/software-mansion/react-native-reanimated/assets/39658211/32ab57fa-37a5-4e3e-abfb-2afdf1a99157 # Testing ```sh cd docs yarn yarn start ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently, there is no way to update props from a worklet imperatively (except for calling JSI bindings
_updatePropsPaperor_updatePropsFabricdirectly, but they are implementation-detail and meant to be private).This PR adds
setNativePropshelper function available on the UI runtime which accepts an animated ref (created withuseAnimatedRef()) along with a plain JS object with props to be updated.At the moment, both Paper and Fabric is supported as well as basic web support works. Proper web support is doable but requires a refactor of
useAnimatedRef.Test plan
SetNativePropsExample.tsx🆕