Restore isConfigured function
#4832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piaskowyk
approved these changes
Jul 27, 2023
piaskowyk
pushed a commit
that referenced
this pull request
Jul 27, 2023
<!-- Thanks for submitting a pull request! We appreciate you spending the time to work on these changes. Please follow the template so that the reviewers can easily understand what the code changes affect. --> ## Summary `isConfigured` was an internal check that due it's directory's `index.ts` having `export * from ./core` was available as a direct import from `react-native-reanimated`. Therefore we cannot simply remove it in a minor version - deleting it raised react-navigation/react-navigation#11498, `react-navigation` uses this function [here](https://github.com/react-navigation/react-navigation/blob/24c03924397a6e59aba9f6b74a9c5cb4b939d9e1/packages/react-native-drawer-layout/src/views/Drawer.tsx#L56) to detect Reanimated 3 since Reanimated 2 didn't have this function. This PR restores this function, marks it as deprecated and adds a separate `public` check to detect Reanimated 3. ## Test plan 🚀 ## Note We should probably locate more functions that are exported as a part of public API but they shouldn't be.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
isConfiguredwas an internal check that due it's directory'sindex.tshavingexport * from ./corewas available as a direct import fromreact-native-reanimated. Therefore we cannot simply remove it in a minor version - deleting it raised react-navigation/react-navigation#11498,react-navigationuses this function here to detect Reanimated 3 since Reanimated 2 didn't have this function.This PR restores this function, marks it as deprecated and adds a separate
publiccheck to detect Reanimated 3.Test plan
🚀
Note
We should probably locate more functions that are exported as a part of public API but they shouldn't be.