Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compatibility table #5122

Merged
merged 24 commits into from
Oct 13, 2023
Merged

Add compatibility table #5122

merged 24 commits into from
Oct 13, 2023

Conversation

Latropos
Copy link
Contributor

@Latropos Latropos commented Sep 22, 2023

Summary

Add compatibility table to docs
Screenshot 2023-10-12 at 11 42 48

@Latropos Latropos marked this pull request as ready for review September 25, 2023 08:12
@Latropos Latropos requested a review from tjzel September 25, 2023 12:59
docs/docs/guides/troubleshooting.mdx Outdated Show resolved Hide resolved
@tjzel
Copy link
Collaborator

tjzel commented Sep 25, 2023

Did we have the same check for Rea2 or no?

@piaskowyk
Copy link
Member

I think we need this for Reanimated 2 too

@Latropos Latropos marked this pull request as draft September 27, 2023 11:32
@Latropos Latropos marked this pull request as ready for review September 27, 2023 12:56
android/build.gradle Outdated Show resolved Hide resolved
android/build.gradle Outdated Show resolved Hide resolved
docs/docs/guides/troubleshooting.mdx Show resolved Hide resolved
scripts/reanimated_utils.rb Outdated Show resolved Hide resolved
docs/docs/guides/troubleshooting.mdx Outdated Show resolved Hide resolved
docs/docs/guides/troubleshooting.mdx Outdated Show resolved Hide resolved
docs/docs/guides/troubleshooting.mdx Outdated Show resolved Hide resolved
docs/docs/guides/troubleshooting.mdx Outdated Show resolved Hide resolved
scripts/reanimated_utils.rb Outdated Show resolved Hide resolved
Copy link
Collaborator

@tjzel tjzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but please change that id.

docs/docs/guides/compatibility.mdx Outdated Show resolved Hide resolved
docs/docs/guides/troubleshooting.mdx Outdated Show resolved Hide resolved
docs/docs/guides/compatibility.mdx Outdated Show resolved Hide resolved
docs/docs/guides/troubleshooting.mdx Outdated Show resolved Hide resolved
docs/docs/guides/troubleshooting.mdx Outdated Show resolved Hide resolved
docs/docs/guides/compatibility.mdx Outdated Show resolved Hide resolved
docs/docs/guides/compatibility.mdx Outdated Show resolved Hide resolved
Copy link
Member

@tomekzaw tomekzaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry but this is not ready to be merged yet

docs/docs/guides/compatibility.mdx Outdated Show resolved Hide resolved
docs/docs/guides/compatibility.mdx Outdated Show resolved Hide resolved
@tomekzaw
Copy link
Member

tomekzaw commented Oct 2, 2023

I'd like to propose the following format of the table:

obraz

Latropos and others added 4 commits October 2, 2023 10:23
Co-authored-by: Kacper Kapuściak <39658211+kacperkapusciak@users.noreply.github.com>
Copy link
Member

@kacperkapusciak kacperkapusciak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Provided the data in the table is correct I would merge it and make the cosmetic changes (if there are any) later on

@Latropos
Copy link
Contributor Author

@kacperkapusciak
I was talking with @tomekzaw and we have decided that we want to create something like below:
Do you think you can add the missing row separator and two additional pieces of inforamation?
That 1️⃣ fabric requires Reanimated 3 and that 2️⃣ we won't be keeping Reanimated 2 up to date
Screenshot 2023-10-12 at 17 06 52

@kacperkapusciak
Copy link
Member

I've added the requested stuff and besides that:

  • Rewrote the compatibility table in markdown for easier maintainance
  • Change the order of tables to the current React Native architecture begin first as it is the default
  • Simplify the sentences informing about support for the New Architecture and Reanimated 3 support
  • I've added dark theme support
  • And, updated the design of the table

Screenshot 2023-10-13 at 15 46 17
Screenshot 2023-10-13 at 15 46 24

@piaskowyk piaskowyk merged commit f300c2c into main Oct 13, 2023
12 of 16 checks passed
@piaskowyk piaskowyk deleted the acynk/compatibility-table branch October 13, 2023 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants