Fix dynamically added/removed animated styles on iOS/Android #5268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wanna add "closing #5296"? |
tomekzaw
reviewed
Nov 6, 2023
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 9, 2024
## Summary Unfortunately, turns out the PR with dynamic styles #5268 introduced more problems than it solved. Thus, proposing a revert. This revert most likely fixed: - #6203 - #6102 - #6037 as well as one more not-published issue and potentially a few more. ## Notes Even if it gets approved, to be merged ONLY after @tjzel agrees with everything ## Test plan 😢 😭
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #5296.
Since this is potentially a JS-heavy fix, I'll gladly listen to suggestions and receive help with how to profile it.
I personally dislike how those changes look like. I would much more prefer to simplify some logic present in
createAnimatedComponentand its devil spawn, reducing some code, instead of building on top of it - although I'm not sure if we need it at the moment.Just watch the video to understand what is happening:
Screen.Recording.2023-10-18.at.19.42.02.mov
Screen.Recording.2023-10-18.at.19.35.24.mov
Test plan
💣
Note
JS-Reanimated (Web implementation) still has those issues and I will produce a separate solution for it in a finite amount of time.