Workletize top-level functions in a file with 'worklet' directive #5554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks correct to me! |
tjzel
force-pushed
the
@tjzel/plugin/allow-file-workletization
branch
from
4f1920e to
ecacb53
Compare
tjzel
force-pushed
the
@tjzel/plugin/allow-file-workletization
branch
from
133377c to
13bfdf9
Compare
tjzel
requested review from
bartlomiejbloniarz and
tomekzaw
and removed request for
bartlomiejbloniarz
This was referenced Sep 24, 2024
This was referenced Oct 1, 2024
This was referenced Oct 3, 2024
This was referenced Oct 4, 2024
This was referenced Oct 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request introduces the mechanism of auto-workletizing the top level of a file.
In a file marked with a
workletdirective every top-level workletizable object (functions, objects with methods) gets workletized.Test plan