Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SET] Tab Navigator support #5793

Merged
merged 76 commits into from
Jun 25, 2024
Merged

[SET] Tab Navigator support #5793

merged 76 commits into from
Jun 25, 2024

Conversation

piaskowyk
Copy link
Member

@piaskowyk piaskowyk commented Mar 15, 2024 •
edited
Loading

Summary

This PR adds support for shared element transition after navigation tab changed.

Screen.Recording.2024-06-04.at.17.16.01.mov

Test plan

Run TabNavigatorExample form Example app.

@bartlomiejbloniarz
Update layout animations
9395a59
@bartlomiejbloniarz
Add example
272399c
@bartlomiejbloniarz
batchinator
fd7aaea
@bartlomiejbloniarz
'use strict' 😭
de8c246
@bartlomiejbloniarz
Mock web
2ee764d
@bartlomiejbloniarz
Fix enableLayoutAnimations call
ee5eae0
@bartlomiejbloniarz
Fix overlapping layout animations
9d480e9
@bartlomiejbloniarz
Fix MethodMetadata
73603db
@bartlomiejbloniarz
Update docs
722ec07
@bartlomiejbloniarz
Merge branch 'main' into @bartlomiejbloniarz/modify-layout-animations
056deb8
@bartlomiejbloniarz
Merge branch 'main' into @bartlomiejbloniarz/modify-layout-animations
9c77015
@bartlomiejbloniarz
Merge branch 'main' into @bartlomiejbloniarz/modify-layout-animations
cc02106
@bartlomiejbloniarz
Big commit
efbd197
@bartlomiejbloniarz
change Android implementation
778fa63
@bartlomiejbloniarz
Remove unnecessary configuration calls
a30284a
@bartlomiejbloniarz
Move animation start to willAppear
aaf7149
@bartlomiejbloniarz
Fix interactivity
f3debe0
@bartlomiejbloniarz
merg
05bac12
@bartlomiejbloniarz
fix java lint
577feea
@bartlomiejbloniarz
Merge branch 'main' into @bartlomiejbloniarz/modify-sets
15974e1
@bartlomiejbloniarz
Add tsdoc
1771706
@bartlomiejbloniarz
Fix transforms on iOS
6adce90
@bartlomiejbloniarz
Simplify configuration
6de03aa
@bartlomiejbloniarz
Remove old api
a9a5461
@bartlomiejbloniarz
Add comment
7b3d4dc
@bartlomiejbloniarz
Fix [SET] Modals example
0b0fcdc
@bartlomiejbloniarz
Change config cleanup
5748249
@bartlomiejbloniarz
Rename listener
c5ae961
@bartlomiejbloniarz
merg
2ccf49e
@bartlomiejbloniarz
Split cleanup for shared transitions
bfd5391
tomekzaw
tomekzaw approved these changes Jun 25, 2024
View reviewed changes
Copy link
Member

@tomekzaw tomekzaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's just make sure that getSharedGroupBlock is properly mocked on iOS.

apps/common-app/src/examples/SharedElementTransitions/TabNavigatorExample.tsx Outdated Show resolved Hide resolved
@piaskowyk piaskowyk enabled auto-merge June 25, 2024 12:54
@piaskowyk piaskowyk added this pull request to the merge queue Jun 25, 2024
Merged via the queue into main with commit 4f1e289 Jun 25, 2024
15 checks passed
@piaskowyk piaskowyk deleted the @piaskowyk/SET-everywhere branch June 25, 2024 12:55
@arenault-pass arenault-pass mentioned this pull request Jul 25, 2024
Closed
This was referenced Jul 25, 2024
Open
Open
@sonlast sonlast mentioned this pull request Jul 27, 2024
Open
@phucle1010 phucle1010 mentioned this pull request Jul 29, 2024
Open
@arenault-pass arenault-pass mentioned this pull request Aug 1, 2024
Closed
@phucle1010 phucle1010 mentioned this pull request Aug 1, 2024
Open
@tiago002pro tiago002pro mentioned this pull request Aug 5, 2024
Open
@snyk-io snyk-io bot mentioned this pull request Aug 12, 2024
Open
@waveyboym waveyboym mentioned this pull request Aug 19, 2024
Closed
@Cabreira97 Cabreira97 mentioned this pull request Aug 23, 2024
Open
@phucle1010 phucle1010 mentioned this pull request Aug 24, 2024
Open
@SanteriMertakorpi SanteriMertakorpi mentioned this pull request Aug 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjzel tjzel tjzel approved these changes

@tomekzaw tomekzaw tomekzaw approved these changes

@bartlomiejbloniarz bartlomiejbloniarz Awaiting requested review from bartlomiejbloniarz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@piaskowyk @tomekzaw @tjzel @bartlomiejbloniarz