Prevent iOS bridgeless initialization from getting the wrong bridge

[gabrieldonadel]

Summary

As I pointed out here, using [RCTBridge currentBridge] may lead to the wrong bridge in apps that have multiple React instances, as is the case for expo-dev-client.

react-native-reanimated/apple/REAModule.mm

Line 284 in 7e1a19e

RCTCxxBridge *cxxBridge = (RCTCxxBridge *)[RCTBridge currentBridge];

Fixes #5497

Instead of using [RCTBridge currentBridge] we can just call self.bridge and ensure the correct bridge is always used

Test plan

Run FabricExample app on iOS

[tomekzaw]

Thanks for the PR!

[tomekzaw]

I wonder if there's anything we can do to prevent us from using currentBridge in the future, maybe some CI checks?

[tsapeta]

I wonder if there's anything we can do to prevent us from using currentBridge in the future, maybe some CI checks?

Why would you need that? This API is going to be deprecated and removed anyway, like everything that relates to the bridge. Also, it's always risky to depend on global things like this. See the comment for currentBridge: https://github.com/facebook/react-native/blob/6262158c11709ea0cbc7603732608046296f39e0/packages/react-native/React/Base/RCTBridge.mm#L252-L261

[tomekzaw]

Why would you need that?

To prevent future us from using this API.

This API is going to be deprecated and removed anyway

Okay, that sounds good

[mym0404]

I'm looking for a way to pass a bridge from ViewManager to View in Fabric.

It seems this code is not run in Fabric ViewManager class.

- (UIView*)view {
  RNCNaverMapViewImpl* ret = [[RNCNaverMapViewImpl alloc] init];
  ret.bridge = self.bridge;

  return ret;
}

Is there any example inject Bridge into View from Fabric ViewManager? Any suggestion or example github repo is welcome.

Note

I need RCTBridge in View because I should use RCTImageLoader for fetch some network image for View

[tsapeta]

@mym0404 As far as I know, there is no way to achieve this. Fabric creates the view instance itself. I think this is intentional as the views shouldn't have any dependencies other than props in order to work properly with the view recycling mechanism.

[mym0404]

@tsapeta understood, thank you for response.