Remove getJSValue
in favor of toJSValue
#6042
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Here's the current implementation of
Shareable::getJSValue
:react-native-reanimated/Common/cpp/SharedItems/Shareables.h
Lines 91 to 93 in e661676
This PR removes
getJSValue
in favor oftoJSValue
as well as updates all usages.Test plan
Just run the Example app.