Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove getJSValue in favor of toJSValue #6042

Merged
merged 2 commits into from
Jun 20, 2024
Merged

Remove getJSValue in favor of toJSValue #6042

merged 2 commits into from
Jun 20, 2024

Conversation

tomekzaw
Copy link
Member

@tomekzaw tomekzaw commented May 23, 2024

Summary

Here's the current implementation of Shareable::getJSValue:

virtual jsi::Value getJSValue(jsi::Runtime &rt) {
return toJSValue(rt);
}

This PR removes getJSValue in favor of toJSValue as well as updates all usages.

Test plan

Just run the Example app.

@tomekzaw tomekzaw added this pull request to the merge queue Jun 20, 2024
Merged via the queue into main with commit 1128a34 Jun 20, 2024
12 checks passed
@tomekzaw tomekzaw deleted the @tomekzaw/toJSValue branch June 20, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants